Remove has_emoji from compiled model serialization format #11

New Issue

kj7rrv · 2022-11-25T19:24:20-08:00

kj7rrv commented

2022-11-25 19:24:20 -08:00

The has_emoji field is now useless (always True) because the emoji module is a hard dependency starting with 3.0.0. Its inclusion in the new model format was merely an oversight. However, it can't be fixed without breaking the model version because 3.0.0 checks for it when loading the model. This definitely isn't a reason to break the model, but it should be done next time the model format is broken for another reason.

The `has_emoji` field is now useless (always True) because the `emoji` module is a hard dependency starting with 3.0.0. Its inclusion in the new model format was merely an oversight. However, it can't be fixed without breaking the model version because 3.0.0 checks for it when loading the model. This definitely isn't a reason to break the model, but it should be done next time the model format is broken for another reason.

kj7rrv added the

enhancement

model-break

wait-for-break

labels 2022-11-25 19:24:37 -08:00

kj7rrv referenced this issue from a commit

2022-11-25 19:44:51 -08:00

Remove most emoji-optional code

kj7rrv referenced this issue from a commit

2022-12-24 11:18:41 -08:00

Remove `has_emoji` and bump model version

kj7rrv closed this issue